Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Theme Selection setting & auto theme switch feature #2

Merged
merged 3 commits into from
Dec 11, 2019
Merged

Added Theme Selection setting & auto theme switch feature #2

merged 3 commits into from
Dec 11, 2019

Conversation

rav-redchamps
Copy link
Contributor

@rav-redchamps rav-redchamps commented Dec 10, 2019 •
edited
Loading

Added Theme Selection setting & auto theme switch feature based on the current time of the day.

setting-1

If "Auto" is selected, then the time slot for the light theme can be chosen from the next setting and outside of that time slot Dark theme will be in use.

P.S. The default value of this new setting is "Auto"

@jakwinkler jakwinkler merged commit 689d5d3 into magespices:master Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbajsarowicz lbajsarowicz lbajsarowicz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rav-redchamps @lbajsarowicz @jakwinkler